Show more

Fixed several RuboCop Node Pattern manual inconsistencies.
It's easy to shoot yourself in the leg with Node Pattern, and the with wrong docs it's easy to be a sharp leg shooter.

Went back and removed some useless stuff from my pull request. Feels good now when I can understand all of it.

Not much this week. Addressed a bunch of things in my `rubocop-rspec` pull request, but there's a ton of things to improve that I originally missed. The primary problem is the cop's size and complexity is growing towards ones of Style/ConditionalAssignment.

Learned (again) the hard way that writing good comments not only helps code reviewers and future contributors to your code, but also yourself. Went back to my +1000 lines pull request to `rubocop-rspec` to address new code review notes after a month not touching this code.

With 56 changed files in 63 commits amendments to those commits are becoming particularly difficult. It's tempting to leave `fixup!` commits in the history, but no.

Advocated for NodePattern part extraction from RuboCop main repository that Jônatas has started.
The current implementation of NodePattern builds Ruby code to walk the tree, while there could be other approaches to the same problem with potentially same performance and less code.

Addressed most of code review notes on RuboCop `rspec-expectations` über-fix.

Submitted a pull request to `rspec-expectations` that fixes all 1700 RuboCop offences.

2019-02-26 Fixed 1300 out of 1700 RuboCop offences in one of the popular gems I use every day.

2019-02-24 Added `Example Group Structure` section to `rspec-style-guide`, rearranged the recommendations to fit the new structure.

2019-02-12..23 Several attempts at fixing `rspec-core`/`mocks`/`expectations` to be global configuration proof in development. Ended up removing my `~/.rspec`.

2019-02-18 Reorganized `let`/`let!` recommendations in `rspec-style-guide`.

2019-02-17 Added a detailed code review for anti-`Timecop` new cop pull request in `rubocop-rails`.

2019-02-08 Submitted a fix for handling of weird subject `hash` change to `rspec-expectations`

2019-02-07 Added hook related recommendations to `rspec-style-guide`

This is going to be a weblog I always wanted. A list of the things I've done. The few following items are for the last month.

Hey people!
Ruby developer with almost a decade of experience here. Glad to meet you all 😌

Ruby.social

A Mastodon instance for Rubyists & friends