Recent searches
Search options
@ioquatix does Coverage.supported? intentionally not recognize oneshot lines mode?
If it should, I did write a quick commit to add it (https://github.com/kevin-j-m/ruby/commit/078a1a80248a4319483b717ee25a26aa030b4a52).
Should I PR it? Do I need to write up something on the issue tracker first? I'm not sure if this documentation means there *must* be an issue, or just to reference it if there is. https://docs.ruby-lang.org/en/master/contributing/making_changes_to_ruby_md.html#label-Commit+messages
Any tips for a first-timer are greatly appreciated!
@kevin_j_m hi, I'm not @ioquatix but I can help here.
The usual way the changes on #ruby core works is to create an entry on https://bugs.ruby-lang.org and after a brief discussion of the necessity, pros & cons of the change it will be approved. The PR may have been created previously.
Of course this is a YMMV, I've seen PR that are clear, concise and right enough that sometimes is approved right there on the PR.
@esparta @kevin_j_m it was probably an oversight because if lines is supported oneshot_lines is also supported IMHO.
@ioquatix thanks for the reply! Should I add it to the issue tracker? And immediately follow up with the PR? Or wait for issue tracker conversation to occur first?
Just want to make sure I'm following protocol!
@kevin_j_m yes it’s very nice for everyone to make an issue first :)
@esparta thanks for the help.